Skip to content

feat: Expose enableAutoattach fields for aws and azure integrations #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Expose enableAutoattach fields for aws and azure integrations #708

wants to merge 5 commits into from

Conversation

@Axot017
Copy link
Contributor

@Axot017 Axot017 commented Dec 3, 2025 •
edited by cursor bot
Loading

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Chore (maintenance work, dependency bumps, refactors, not supposed to break existing functionalities)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (non-breaking change that adds documentation)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • Examples for new resources and data sources have been added
  • Default values have been documented in the description (e.g., "Dummy: (Boolean) Blah blah. Defaults to false.)
  • If the action fails that checks the documentation: Run go generate to make sure the docs are up to date

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Pull Request is no longer marked as "draft"
  • Reviewers have been assigned
  • Changes have been reviewed by at least one other engineer

Note

Expose autoattach_enabled boolean across AWS and Azure integrations in resources, data sources, GraphQL wiring, docs, and tests.

  • Provider schemas:
    • AWS: add autoattach_enabled to spacelift_aws_integration resource and spacelift_aws_integration/spacelift_aws_integrations data sources (computed in data sources, optional in resource with default false).
    • Azure: add autoattach_enabled to spacelift_azure_integration resource and spacelift_azure_integration/spacelift_azure_integrations data sources (computed in data sources, optional in resource with default false).
  • GraphQL & structs:
    • Wire autoattachEnabled through create/update mutations and map/read paths.
    • Extend AWSIntegration and AzureIntegration structs and ToMap() to include autoattach_enabled.
  • Tests:
    • Update resource and data source tests to set/assert autoattach_enabled for AWS and Azure.
    • Adjust AWS integrations data test to pass checks into CheckInList.
  • Docs:
    • Document autoattach_enabled in relevant resources and data sources.

Written by Cursor Bugbot for commit 7abfd61. This will update automatically on new commits. Configure here.

@Axot017 Axot017 force-pushed the expose-enable-autoattach-field branch 3 times, most recently from f63039f to ac941be Compare December 3, 2025 11:10
@Axot017 Axot017 marked this pull request as ready for review December 3, 2025 11:36
cursor[bot]
cursor bot reviewed Dec 3, 2025
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 8

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@Axot017 Axot017 force-pushed the expose-enable-autoattach-field branch from ac941be to 7cc600e Compare December 3, 2025 11:56
mbialon
mbialon previously approved these changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@mbialon mbialon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Axot017 Axot017 requested a review from mbialon December 4, 2025 11:38
@Axot017 Axot017 enabled auto-merge (squash) December 4, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@mbialon mbialon mbialon approved these changes

@eliecharra eliecharra Awaiting requested review from eliecharra

@tomasmik tomasmik Awaiting requested review from tomasmik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Axot017 @mbialon